From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: tc358762: Various small fixes Date: Sat, 16 May 2026 12:04:20 +1000 Message-ID: In-Reply-To: <20260513-tc358762-fixes-v3-0-6698b55008b9@ideasonboard.com> References: <20260513-tc358762-fixes-v3-0-6698b55008b9@ideasonboard.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: tc358762: Various small fixes Author: Tomi Valkeinen Patches: 14 Reviewed: 2026-05-16T12:04:20.988257 --- This is a well-structured 13-patch series from Tomi Valkeinen fixing the TC= 358762 DSI-to-DPI bridge driver. The series progresses logically: first cle= aning up register defines (patches 1-3), then reordering initialization (pa= tch 4), removing dead code (patch 5), fixing DPI enable sequencing (patch 6= ), documenting constraints (patch 7), adding VTG support (patch 8), fixing = polarity bugs (patches 9, 12), refactoring (patches 10-11), and finally fix= ing the companion panel timings (patch 13). The register define corrections in patch 3 are the key insight =E2=80=94 th= e old defines were wrong but happened to produce the correct bit pattern by= coincidence (`LCDCTRL_VSDELAY(1) | LCDCTRL_RGB888 | LCDCTRL_UNK6 | LCDCTRL= _VTGEN` =3D `FIELD_PREP(LCDCTRL_PXLFORM, RGB888) | LCDCTRL_DPI_EN | LCDCTRL= _DCLK_POL` =3D 0x100150). I verified both the SYSCTRL (0x040f) and LCDCTRL = (0x100150) values are preserved exactly through the define cleanup, so the = "no functional change" claim is correct. The series is well-ordered for bisectability and each patch is reasonably s= elf-contained. One issue worth flagging is the missing NULL checks in patch= 11. **Recommendation: Looks good overall. One minor issue (missing NULL check) = worth addressing.** --- Generated by Claude Code Patch Reviewer