From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/loongson: Use managed KMS polling Date: Sat, 16 May 2026 12:30:12 +1000 Message-ID: In-Reply-To: <20260513065706.23803-1-mhun512@gmail.com> References: <20260513065706.23803-1-mhun512@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/loongson: Use managed KMS polling Author: Myeonghun Pak Patches: 1 Reviewed: 2026-05-16T12:30:12.889221 --- This is a single-patch series that replaces `drm_kms_helper_poll_init()` wi= th its managed counterpart `drmm_kms_helper_poll_init()` in the loongson LS= DC driver. The change is correct, well-motivated, and has already been revi= ewed/acked by the relevant maintainers. **Assessment: Good to merge.** The commit message clearly identifies the problem: `drm_kms_helper_poll_ini= t()` is called early in probe, but if later steps (`drm_vblank_init`, `devm= _request_irq`, `drm_dev_register`) fail, the driver returns without calling= `drm_kms_helper_poll_fini()`. Additionally, `lsdc_pci_remove()` (line 324-= 330 in the current tree) never calls `drm_kms_helper_poll_fini()` either = =E2=80=94 it only does `drm_dev_unregister()` and `drm_atomic_helper_shutdo= wn()`. Using `drmm_kms_helper_poll_init()` ties the polling lifecycle to th= e DRM device managed cleanup, fixing both the error-path leak and the missi= ng finalization on removal. --- Generated by Claude Code Patch Reviewer