From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add eDP support for RK3576 Date: Sat, 16 May 2026 12:26:16 +1000 Message-ID: In-Reply-To: <20260513074414.2053435-1-damon.ding@rock-chips.com> References: <20260513074414.2053435-1-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add eDP support for RK3576 Author: Damon Ding Patches: 13 Reviewed: 2026-05-16T12:26:16.190442 --- This is a well-structured 10-patch series adding eDP support for the Rockchip RK3576 SoC, building on the existing RK3588 eDP infrastructure. The series is cleanly organized into three logical groups: (1) fixing the missing `hclk` bus clock for RK3588 eDP (patches 1-5), (2) adding the RK3576 eDP DT node (patches 6-7), and (3) adding driver support for RK3576 (patches 8-10). The changes are minimal and follow existing patterns well. The DT binding updates correctly use per-compatible `if/then` blocks to enforce clock names. The driver reuses the RK3588 configuration for RK3576, which is stated to share the same hardware design. Most patches already carry Reviewed-by or Acked-by tags. No significant issues found. A couple of minor observations below. --- --- Generated by Claude Code Patch Reviewer