From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: arm64: dts: qcom: pixel 3a xl support with tianma panel Date: Sat, 16 May 2026 11:37:15 +1000 Message-ID: In-Reply-To: <20260513172549.1345-1-mailingradian@gmail.com> References: <20260513172549.1345-1-mailingradian@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: arm64: dts: qcom: pixel 3a xl support with tianma panel Author: Richard Acayan Patches: 5 Reviewed: 2026-05-16T11:37:15.551397 --- This is a clean, well-structured 2-patch series that refactors the existing= Pixel 3a (sargo) device tree to extract common hardware definitions into a= shared `.dtsi` include, then adds a new Pixel 3a XL (bonito) variant with = the Tianma/Novatek panel. The approach follows established DT patterns for sharing code between devic= e variants. The factoring decisions are sensible =E2=80=94 device-specific = properties (model, compatible, battery capacity, display height, panel comp= atible, touchscreen dimensions) are correctly moved to per-device `.dts` fi= les, while all shared SoC/board configuration stays in the common include. The series has Reviewed-by from Konrad Dybcio on both patches, proper AI as= sistance disclosure, and the cover letter is thorough. The `novatek,nt37700= f` compatible already has both a binding and a driver in the tree, so the n= ew device tree will work out of the box. **No blocking issues.** A few minor observations below. --- --- Generated by Claude Code Patch Reviewer