From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel: ethosu: Validate SRAM size on submit
Date: Sat, 16 May 2026 11:22:18 +1000 [thread overview]
Message-ID: <review-overall-20260513185434.1667045-1-robh@kernel.org> (raw)
In-Reply-To: <20260513185434.1667045-1-robh@kernel.org>
Overall Series Review
Subject: accel: ethosu: Validate SRAM size on submit
Author: "Rob Herring (Arm)" <robh@kernel.org>
Patches: 1
Reviewed: 2026-05-16T11:22:18.689614
---
This is a single-patch security fix for the Arm Ethos-U NPU accelerator driver. The patch addresses a real input validation gap: the command stream's region size for the SRAM region was not being validated against the hardware's actual SRAM size. The old code only checked `job->sram_size` (a user-supplied value from the ioctl), which as the commit message correctly notes, a malicious userspace could lie about. The fix validates against `edev->npu_info.sram_size`, which is the kernel-authoritative value derived from the hardware's gen_pool.
The patch is well-motivated and correct in its approach. One minor nit exists.
**Verdict: Looks good, one minor observation.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 1:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 18:54 [PATCH] accel: ethosu: Validate SRAM size on submit Rob Herring (Arm)
2026-05-16 1:22 ` Claude Code Review Bot [this message]
2026-05-16 1:22 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260513185434.1667045-1-robh@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox