From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: cgroup/dmem: introduce a peak file Date: Sat, 16 May 2026 10:32:53 +1000 Message-ID: In-Reply-To: <20260514-dmem_peak-v3-1-b64ce5d3ac38@igalia.com> References: <20260514-dmem_peak-v3-1-b64ce5d3ac38@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: cgroup/dmem: introduce a peak file Author: Thadeu Lima de Souza Cascardo Patches: 1 Reviewed: 2026-05-16T10:32:53.178730 --- This is a single-patch series (v3) that adds a read-only `dmem.peak` file t= o the dmem cgroup controller, mirroring the existing `memory.peak` concept.= The implementation is clean and minimal =E2=80=94 it reuses the existing `= page_counter` watermark infrastructure and the `dmemcg_limit_show` callback= pattern already established for `dmem.current`. The patch is **correct and safe to merge** with minor nits. The watermark i= s already maintained hierarchically by `page_counter_try_charge()` / `page_= counter_charge()`, so no additional charge-path changes are needed. The `RE= AD_ONCE` usage is appropriate and matches how the memory controller reads t= he watermark. **Issues worth noting:** 1. **Incomplete changelog**: The v3 changelog still contains `EDITME` place= holders =E2=80=94 this should be fixed before merge, though it's metadata o= nly. 2. **No selftest coverage**: There's no selftest for this new file, and no = existing dmem selftest infrastructure was found. A basic test would strengt= hen the patch. 3. **Read-only vs. read-write**: The commit message says "for now, make it = read-only." The memory controller's `memory.peak` is read-write (writing re= sets the peak per-FD). This is fine as stated =E2=80=94 reset support can c= ome later =E2=80=94 but the documentation should probably mention this diff= erence more explicitly or note that reset support is planned. --- --- Generated by Claude Code Patch Reviewer