From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fbdev: fix various memory leaks Date: Sat, 16 May 2026 11:10:39 +1000 Message-ID: In-Reply-To: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> References: <20260514-fbdev-v1-0-b3a2474fa720@cse.iitm.ac.in> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: fbdev: fix various memory leaks Author: Abdun Nihaal Patches: 20 Reviewed: 2026-05-16T11:10:39.648581 --- This is a 14-patch series from Abdun Nihaal fixing various memory leaks in fbdev drivers, found via static analysis. The series falls into four categories: (1) missing cleanup of `fb_deferred_io_init()` pageref allocations, (2) missing `fb_destroy_modelist()` on error paths, (3) missing `kfree()` of option strings from `fb_get_options()`, and (4) a missing `kfree()` of EDID data. All patches were compile-tested only. Overall the series is well-structured, clearly described, and the cover letter does a good job grouping the fixes by root cause. Most patches are straightforward and correct. However, there are issues in patches 4 (radeon), 7 (nvidia), and 14 (sm501fb) that need attention, and patches 12 and 13 (efifb/vesafb) need verification of the ownership claim about `fb_get_options()`. **Verdict: Mostly good, a few patches need revision or closer scrutiny.** --- --- Generated by Claude Code Patch Reviewer