From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/panel: Add panel driver for Chipone ICNA35XX based panels Date: Sat, 16 May 2026 10:36:59 +1000 Message-ID: In-Reply-To: <20260514-icna35xx-v2-0-45acd1dfa566@gmail.com> References: <20260514-icna35xx-v2-0-45acd1dfa566@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/panel: Add panel driver for Chipone ICNA35XX based panels Author: Aaron Kling via B4 Relay Patches: 10 Reviewed: 2026-05-16T10:36:59.921908 --- This is a v2 series adding a DRM panel driver for Chipone ICNA35xx DDICs (ICNA3512 / ICNA3520) used in AYN handheld gaming devices. The series is 2 patches: DT bindings + driver. It depends on a prerequisite AYN QCS8550 DT series. The driver uses modern APIs (`devm_drm_panel_alloc`, `devm_regulator_bulk_get_const`, `mipi_dsi_multi_context`) which is good. However, there are several issues: the `panel_desc` structs should be `const`, there's a stale `connector` pointer stashed in the panel's private struct (fragile anti-pattern), an unnecessary include, and a const-discarding cast. The DT binding looks mostly fine. Overall the driver is in reasonable shape but needs a cleanup pass before merging. --- --- Generated by Claude Code Patch Reviewer