Claude review: drm/panel: Add panel driver for Chipone ICNA35XX based panels

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/panel: Add panel driver for Chipone ICNA35XX based panels
Author: Aaron Kling via B4 Relay <devnull+webgeek1234.gmail.com@kernel.org>
Patches: 3
Reviewed: 2026-05-16T10:22:32.473513

---

This is a v3 two-patch series adding a DRM panel driver for Chipone ICNA3512/ICNA3520 DDICs used in AYN and Ayaneo handheld gaming devices. The overall structure is sound and follows modern kernel panel driver conventions (`devm_drm_panel_alloc`, `mipi_dsi_multi_context`, `devm_regulator_bulk_get_const`). The DT binding is clean and correctly structured.

The driver works but has several issues ranging from likely bugs (swapped physical dimensions) to style/modernization items. The `get_current_mode` pattern is established (matches `panel-novatek-nt35950`), the minimal DSC config matches `panel-visionox-r66451`, and the overall probe/remove flow is correct.

**Key concerns:**
1. The `width_mm`/`height_mm` values appear to be swapped for both panels (likely bug).
2. The driver could use `devm_mipi_dsi_attach()` to simplify/eliminate the `.remove` callback.
3. Unnecessary `#include <linux/of_graph.h>`.
4. Minor style nits (indentation, `__typeof` vs struct name directly).

---

---
Generated by Claude Code Patch Reviewer