From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: fastrpc: Reduce log level for DSP info and reserved memory messages Date: Sat, 16 May 2026 11:18:47 +1000 Message-ID: In-Reply-To: <20260514062825.50172-1-jianping.li@oss.qualcomm.com> References: <20260514062825.50172-1-jianping.li@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: fastrpc: Reduce log level for DSP info and reserved memory messages Author: Jianping Li Patches: 1 Reviewed: 2026-05-16T11:18:47.374563 --- This is a single, straightforward patch that downgrades two log messages in= the fastrpc driver from `dev_err`/`dev_info` to `dev_dbg`. The rationale i= s reasonable: both messages can fire repeatedly during boot on certain plat= forms and don't represent true error conditions. The patch is small, well-s= coped, and the commit message clearly explains the motivation. **Minor concerns exist with the first hunk** =E2=80=94 the DSP information = error path does return a non-zero error code to the ioctl caller, so silenc= ing it completely to `dev_dbg` may make debugging harder for developers who= don't have dynamic debug enabled. The second hunk (reserved memory) is cle= arly correct since absence of reserved DMA memory is explicitly described a= s a valid configuration. No functional issues. No correctness problems. --- Generated by Claude Code Patch Reviewer