From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/vmwgfx: Never destroy STDU zero's Screen Target Date: Sat, 16 May 2026 10:41:44 +1000 Message-ID: In-Reply-To: <20260514153103.1465013-1-ian.forbes@broadcom.com> References: <20260514153103.1465013-1-ian.forbes@broadcom.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/vmwgfx: Never destroy STDU zero's Screen Target Author: Ian Forbes Patches: 1 Reviewed: 2026-05-16T10:41:44.665104 --- This is a single-patch fix for the VMware SVGA Screen Target Display Unit (= STDU) driver. The patch addresses a real usability problem: when a VM displ= ay goes to sleep and the CRTC is disabled, the Screen Target for display un= it 0 gets destroyed, which causes some VMware clients to fail to create a w= indow (since they query existing screen target info to determine window siz= e). Without a window, the user can't provide input to wake the VM. The fix is simple and narrowly scoped =E2=80=94 it adds an early return in = `vmw_stdu_crtc_atomic_disable()` for unit 0, preventing the Screen Target f= rom being destroyed. The approach is reasonable and consistent with how the= driver already handles the "inactive but enabled" case (the existing early= return at lines 446-449). **Verdict: Looks correct and well-motivated. One minor concern worth discus= sing below.** --- Generated by Claude Code Patch Reviewer