From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdkfd: Fix UML build guards for x86_64-only code Date: Sat, 16 May 2026 10:39:53 +1000 Message-ID: In-Reply-To: <20260514170139.335618-1-alex.hung@amd.com> References: <20260514170139.335618-1-alex.hung@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amdkfd: Fix UML build guards for x86_64-only code Author: Alex Hung Patches: 2 Reviewed: 2026-05-16T10:39:53.035340 --- This is a single patch fixing a UML build failure in `amdkfd` by adding `!d= efined(CONFIG_UML)` guards alongside existing `CONFIG_X86_64` guards. The p= roblem is that UML defines `CONFIG_X86_64` (inheriting the host architectur= e) but does not provide x86-specific CPU data structures like `cpu_data()` = and `cpuinfo_x86`. The patch is a straightforward and correct fix. All four `CONFIG_X86_64` gu= ard sites that use x86-specific APIs are updated, and the existing `#else` = fallback paths handle the non-x86 case appropriately (returning a default v= alue or printing a diagnostic). No x86-specific code sites appear to be mis= sed. One notable observation: the current drm-next tree still has `depends on !U= ML` in `drivers/gpu/drm/amd/amdgpu/Kconfig:6`, which would prevent this bui= ld failure from occurring. This patch is a companion fix for `e6b71bcdc409 = ("drm/amdgpu: Remove UML build exclusion from Kconfig")` =E2=80=94 it only = becomes necessary once that commit lands. The ordering dependency should be= confirmed so the build doesn't break in an intermediate bisection state. **Verdict: Patch looks correct.** Minor comments below. --- --- Generated by Claude Code Patch Reviewer