Claude review: drm/amdgpu: clamp user gartsize against device capacity

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/amdgpu: clamp user gartsize against device capacity
Author: Ahmed Elmetwally <en22ue@gmail.com>
Patches: 1
Reviewed: 2026-05-16T10:27:15.093189

---

**This patch is based on a stale tree and will not apply.** The upstream code has already been refactored: the inline gart size logic in each `gmc_v*_0.c` backend was consolidated into a shared `amdgpu_gmc_set_gart_size()` helper (see `amdgpu_gmc.c:283`). The patch's diff context in `gmc_v11_0.c` expects the old inline code (`if (amdgpu_gart_size == -1) ... else ...`) which no longer exists — the current tree has a single call to `amdgpu_gmc_set_gart_size(adev, SZ_512M)` at line 712.

The underlying problem (an absurdly large `amdgpu.gartsize` parameter causing probe failure) is real and the commit message is well-written with a clear reproducer. However, the correct fix should modify the existing `amdgpu_gmc_set_gart_size()` function rather than introducing a parallel `amdgpu_gmc_validate_gart_size()` helper. This would fix all gmc backends (v6 through v12) in one shot rather than requiring per-backend follow-up patches.

Additionally, the patch has several technical issues detailed below.

---

---
Generated by Claude Code Patch Reviewer