From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: DRM RAS Fixes
Date: Sat, 16 May 2026 10:24:55 +1000 [thread overview]
Message-ID: <review-overall-20260514202839.1888688-1-raag.jadav@intel.com> (raw)
In-Reply-To: <20260514202839.1888688-1-raag.jadav@intel.com>
Overall Series Review
Subject: DRM RAS Fixes
Author: Raag Jadav <raag.jadav@intel.com>
Patches: 4
Reviewed: 2026-05-16T10:24:55.790178
---
This is a 3-patch series fixing resource leak and cleanup issues in the DRM RAS (Reliability, Availability, Serviceability) infrastructure and the Xe driver's use of it. The fixes are real and the direction is correct: patch 1 plugs a netlink message leak, patch 2 switches to managed allocation, and patch 3 moves to per-node cleanup actions for robust unwind. However, **patch 3 has a double-cleanup bug** on the `drmm_add_action_or_reset` failure path that needs to be fixed before merging.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-16 0:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 20:28 [PATCH v1 0/3] DRM RAS Fixes Raag Jadav
2026-05-14 20:28 ` [PATCH v1 1/3] drm/ras: Cancel and free message on get counter failure Raag Jadav
2026-05-16 0:24 ` Claude review: " Claude Code Review Bot
2026-05-14 20:28 ` [PATCH v1 2/3] drm/xe/drm_ras: Make counter allocation drm managed Raag Jadav
2026-05-16 0:24 ` Claude review: " Claude Code Review Bot
2026-05-14 20:28 ` [PATCH v1 3/3] drm/xe/drm_ras: Add per node cleanup action Raag Jadav
2026-05-16 0:24 ` Claude review: " Claude Code Review Bot
2026-05-16 0:24 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260514202839.1888688-1-raag.jadav@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox