From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add support for Adreno 810 GPU Date: Sat, 16 May 2026 10:05:40 +1000 Message-ID: In-Reply-To: <20260515-adreno-810-v6-0-fbe04c7203e1@pm.me> References: <20260515-adreno-810-v6-0-fbe04c7203e1@pm.me> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add support for Adreno 810 GPU Author: Alexander Koskovich Patches: 9 Reviewed: 2026-05-16T10:05:40.670319 --- This is a well-structured 7-patch RFC series adding Adreno 810 GPU support = for the Qualcomm SM7635 (Milos) SoC. The series follows the established pat= terns for A8XX GPU enablement, building on the existing X285 and A840 suppo= rt. The preparatory patches (3-5) are cleanly separated and make the subseq= uent enablement patch possible. The series is in good shape overall. The main technical concern is around p= atch 5 (pipe protect slot hardcoding) =E2=80=94 while the fix is correct, t= he `count_max` field now has inconsistent semantics across A8XX GPUs and th= e existing X285/A840 entries should arguably be updated to match. There's a= lso an unused helper function added in patch 6. The series has appropriate review tags from Qualcomm engineers on the prepa= ratory patches. Patch 6 (the main enablement) and patch 7 (DTS) still need = reviews. --- --- Generated by Claude Code Patch Reviewer