From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: imx93-mipi-dsi: Fix mode validation Date: Sat, 16 May 2026 09:49:36 +1000 Message-ID: In-Reply-To: <20260515-imx93-mipi-dsi-fix-mode-validation-v3-1-91f7d22b2fe4@nxp.com> References: <20260515-imx93-mipi-dsi-fix-mode-validation-v3-1-91f7d22b2fe4@nxp.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: imx93-mipi-dsi: Fix mode validation Author: Liu Ying Patches: 1 Reviewed: 2026-05-16T09:49:36.532814 --- This is a single-patch fix for mode validation in the i.MX93 MIPI DSI bridg= e driver. The problem: the old code checked only the **last** bridge in the= chain for `DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID`, but when the last b= ridge is a connector bridge (with no ops set), the check always fails, and = the +/-0.5% pixel clock deviation tolerance is never applied. The fix itera= tes over all bridges after the DSI bridge, looking for the first one that h= as both ops set. The patch is well-reasoned and correct. The refcounting is handled properly= in all paths (normal exit, early return on `MODE_NOCLOCK`, loop exhaustion= ). The manual iteration (instead of using `drm_for_each_bridge_in_chain_fro= m()`) is the right approach because `bridge_chain_mutex` is already held by= the caller `drm_bridge_chain_mode_valid()` =E2=80=94 using the macro would= deadlock. This was identified in v2 review and fixed in v3. **Verdict: Looks good.** One minor observation below but nothing blocking. --- --- Generated by Claude Code Patch Reviewer