From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: kunit: Add support for suppressing warning backtraces Date: Sat, 16 May 2026 09:36:17 +1000 Message-ID: In-Reply-To: <20260515-kunit_add_support-v12-0-a216dc228be8@redhat.com> References: <20260515-kunit_add_support-v12-0-a216dc228be8@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: kunit: Add support for suppressing warning backtraces Author: Albert Esteve Patches: 6 Reviewed: 2026-05-16T09:36:17.052981 --- This is a well-engineered v12 series adding KUnit warning backtrace suppression, with reviews from Kees Cook and David Gow. The design is solid: task-scoped suppression via the existing KUnit hooks mechanism, RCU for readers/spinlock for writers, `call_rcu()` for safe deferred freeing, and `get_task_struct()` to prevent ABA false positives on task matching. The three suppression injection points (`warn_slowpath_fmt`, `__warn_printk`, `__report_bug`) correctly cover all architecture variants with the `count` bool preventing double-counting. The series is in good shape overall. I have one substantive concern about the multi-scope self-test accessing handles after their deferred free has been scheduled, plus a few minor observations. --- Generated by Claude Code Patch Reviewer