From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: kunit: Add support for suppressing warning backtraces Date: Sat, 16 May 2026 09:18:00 +1000 Message-ID: In-Reply-To: <20260515-kunit_add_support-v13-0-18ee42f96e7b@redhat.com> References: <20260515-kunit_add_support-v13-0-18ee42f96e7b@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: kunit: Add support for suppressing warning backtraces Author: Albert Esteve Patches: 9 Reviewed: 2026-05-16T09:18:00.257637 --- This is a well-evolved v13 series (originally RFC by Alessandro Carminati, = carried forward by Guenter Roeck, now stewarded by Albert Esteve) adding KU= nit warning backtrace suppression. The design is solid: task-scoped suppres= sion integrated into the existing KUnit hooks infrastructure, with zero ove= rhead when no tests are running (via the `kunit_running` static branch). Th= e series is cleanly split into infrastructure, tests, a real-world user, an= d documentation. **Strengths:** - Clean integration into existing KUnit hooks =E2=80=94 no new config optio= ns, no arch-specific code - Three suppression points covering both `__WARN_FLAGS` and non-`__WARN_FLA= GS` architectures - The `count` parameter to `kunit_is_suppressed_warning()` elegantly solves= the double-counting problem - The `in_task()` guard prevents false suppression from hardirq context - Good test coverage including cross-kthread isolation - Scoped API using `__cleanup` attribute is ergonomic **Concerns (minor):** - The `synchronize_rcu()` in cleanup path could add measurable latency in t= est suites with many suppression scopes, though it's correct - The nesting prohibition (only one active suppression per task) may be lim= iting for complex test helpers, but is reasonable for v1 Overall this looks ready to merge with the reviews it already has (David Go= w, Kees Cook). A few minor observations follow. --- --- Generated by Claude Code Patch Reviewer