From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: nova-core: run unload sequence upon unbinding Date: Sat, 16 May 2026 09:54:07 +1000 Message-ID: In-Reply-To: <20260515-nova-unload-v5-0-c4d6250ad160@nvidia.com> References: <20260515-nova-unload-v5-0-c4d6250ad160@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: gpu: nova-core: run unload sequence upon unbinding Author: Alexandre Courbot Patches: 8 Reviewed: 2026-05-16T09:54:07.385671 --- This is a well-structured 7-patch series from Alexandre Courbot (NVIDIA) implementing GSP firmware unloading for the nova-core driver, enabling clean GPU teardown on driver unbind. The series is at v5, rebased on the Device HRT series, and follows a logical progression: cleanup (patches 1-2), GSP shutdown command (patch 3), SEC2 refactoring (patch 4), boot code reorganization (patches 5-6 for HAL extraction), and the actual unload sequence (patch 7). The overall design is sound: firmware required for unloading is pre-loaded at boot time (since the filesystem may not be accessible at unbind), stored in a trait-object `UnloadBundle`, and executed during the unbind path. The HAL abstraction cleanly separates the Turing/Ampere/Ada SEC2 boot path from the Hopper/Blackwell FSP path (currently a stub). The series has appropriate reviews on the cleanup patches (1-4) from Eliot Courtney and Gary Guo, but patches 5-7 lack Reviewed-by tags. Patches 5 and 6 are described as purely mechanical but are large enough to warrant review attention. I have a few observations, mostly minor, but one item on patch 5's reordering deserves attention. --- --- Generated by Claude Code Patch Reviewer