From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: video: fbdev: sm712: Fix operator precedence in big_swap macro Date: Sat, 16 May 2026 10:14:54 +1000 Message-ID: In-Reply-To: <20260515010202.2506-1-lirongqing@baidu.com> References: <20260515010202.2506-1-lirongqing@baidu.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: video: fbdev: sm712: Fix operator precedence in big_swap macro Author: lirongqing Patches: 1 Reviewed: 2026-05-16T10:14:54.297228 --- This is a single-patch series fixing a genuine operator precedence bug in the `big_swap` macro in the SM712 fbdev driver. The fix is correct and straightforward. The bug has been present since the code was merged from staging (`1461d66728648`), meaning the big-endian byte swap path has been silently broken for the entire lifetime of this driver in the fbdev tree. The fix is low-risk and clearly correct. **Recommend: Accept.** One minor observation: the macro arguments still lack parenthesizing of `p` itself (i.e., it should ideally be `(((p) & 0xff00ff00) >> 8) | (((p) & 0x00ff00ff) << 8)`) to protect against macro argument expansion issues if `p` is an expression. However, the existing callers at `sm712fb.c:1010`, `sm712fb.c:1069`, and `sm712fb.c:1141` all pass simple identifiers (`val`, `val`, `*src`), so this is a pre-existing style issue rather than a bug, and it's reasonable not to address it here. --- Generated by Claude Code Patch Reviewer