From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: synopsys: dw-dp: fix bool function returning negative error code Date: Sat, 16 May 2026 10:13:40 +1000 Message-ID: In-Reply-To: <20260515020156.601-1-yanlonglong@kylinos.cn> References: <20260515020156.601-1-yanlonglong@kylinos.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: synopsys: dw-dp: fix bool function returning negative = error code Author: Bob ynn Patches: 1 Reviewed: 2026-05-16T10:13:40.480504 --- This is a single-patch fix for a real bug: the bool-returning function `dw_= dp_video_need_vsc_sdp()` was returning `-EINVAL` (a non-zero integer) on er= ror, which gets implicitly converted to `true`. This would incorrectly caus= e the VSC SDP flag (`DP_MSA_MISC_COLOR_VSC_SDP`) to be set in the MSA when = `dw_dp_get_bridge_state()` fails, which is the opposite of safe/correct beh= avior. Returning `false` on failure is the right conservative choice =E2=80= =94 if we can't determine the bridge state, we shouldn't claim a VSC SDP is= needed. The fix is correct, minimal, and appropriate. **Recommend: Accept.** --- Generated by Claude Code Patch Reviewer