From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/radeon: avoid printing NULL strings
Date: Sat, 16 May 2026 09:25:34 +1000 [thread overview]
Message-ID: <review-overall-20260515091054.529610-1-arnd@kernel.org> (raw)
In-Reply-To: <20260515091054.529610-1-arnd@kernel.org>
Overall Series Review
Subject: drm/radeon: avoid printing NULL strings
Author: Arnd Bergmann <arnd@kernel.org>
Patches: 1
Reviewed: 2026-05-16T09:25:34.687919
---
This is a single-patch fix from Arnd Bergmann addressing a `-Wformat-overflow` warning from gcc-10. The compiler detects that `evergreen_surface_check()` is called with a `NULL` third argument (`prefix`), and that `prefix` is used in `dev_warn()` `%s` format strings, triggering a build failure with `-Werror`.
The fix is correct and minimal — it replaces `NULL` with `""` at the three call sites. However, there is a subtle **behavioral change** worth noting.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-15 23:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 9:10 [PATCH] drm/radeon: avoid printing NULL strings Arnd Bergmann
2026-05-15 23:25 ` Claude Code Review Bot [this message]
2026-05-15 23:25 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260515091054.529610-1-arnd@kernel.org \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox