From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Add missing bug fixes Date: Sat, 16 May 2026 09:15:13 +1000 Message-ID: In-Reply-To: <20260515124010.20679-1-jianping.li@oss.qualcomm.com> References: <20260515124010.20679-1-jianping.li@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: misc: fastrpc: Add missing bug fixes Author: Jianping Li Patches: 1 Reviewed: 2026-05-16T09:15:13.576580 --- This is a 5-patch series fixing memory management issues in the FastRPC dri= ver, focused on the Audio PD remote heap. The core problem is well-motivate= d: userspace-controlled alloc/free of the reserved memory region shared wit= h the DSP is unsafe because the kernel cannot know when the DSP is done wit= h the buffers. The solution moves the reserved memory lifecycle to be tied = to the rpmsg channel (probe/remove). The series has some real fixes (patches 1, 2) and a significant architectur= al change (patch 4) that restructures how Audio PD memory is handled. Howev= er, **patch 4 has several concerning issues** including a memory leak on er= ror, incomplete initialization of the `remote_heap` struct, and questionabl= e use of a spinlock around non-atomic operations. Patch 3 is effectively su= perseded by patch 4 =E2=80=94 it adds validation that patch 4 then restruct= ures, making the Fixes/stable tags on patch 3 questionable. --- Generated by Claude Code Patch Reviewer