From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Add missing bug fixes Date: Sat, 16 May 2026 09:09:53 +1000 Message-ID: In-Reply-To: <20260515124217.20723-1-jianping.li@oss.qualcomm.com> References: <20260515124217.20723-1-jianping.li@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: misc: fastrpc: Add missing bug fixes Author: Jianping Li Patches: 10 Reviewed: 2026-05-16T09:09:53.913817 --- This v5 series addresses multiple memory handling bugs in the FastRPC Audio PD remote heap. The first three patches are self-contained bug fixes with `Fixes:` tags and `Cc: stable`, while patches 4-5 are structural improvements that supersede some of the earlier fixes in mainline. The series has a **sound overall design**: moving Audio PD reserved-memory allocation to rpmsg probe and tying its lifetime to the channel is the right approach. However, **patch 4 has two memory leak bugs in error paths** and an unconditional `audio_init_mem = false` reset that can affect concurrent users. Patch 2 is solid and correctly addresses the race. Patches 1, 3, and 5 are clean fixes/cleanups. **Recommendation:** Patches 1, 2, 3, and 5 look good. Patch 4 needs fixes for the error paths in probe and the `err_invoke` label logic before it can be merged. --- --- Generated by Claude Code Patch Reviewer