From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/amdxdna: Remove mmap and export support for ubuf Date: Sat, 16 May 2026 08:56:25 +1000 Message-ID: In-Reply-To: <20260515155332.743097-1-lizhi.hou@amd.com> References: <20260515155332.743097-1-lizhi.hou@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel/amdxdna: Remove mmap and export support for ubuf Author: Lizhi Hou Patches: 1 Reviewed: 2026-05-16T08:56:25.802864 --- This is a single patch that removes mmap, vmap, and vunmap support from the `amdxdna_ubuf_dmabuf_ops` and blocks re-export of ubuf-backed GEM objects. The intent is reasonable: ubuf wraps user-pinned pages, and re-exporting or mmapping through the dma-buf is problematic (the user already has direct access to the memory). The patch is small and the deletion side is clean. However, there are two issues worth discussing: dead code left behind, and a poorly named flag. --- Generated by Claude Code Patch Reviewer