From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: accel/amdxdna: Add expandable device heap support
Date: Sat, 16 May 2026 08:50:25 +1000 [thread overview]
Message-ID: <review-overall-20260515161922.744647-1-lizhi.hou@amd.com> (raw)
In-Reply-To: <20260515161922.744647-1-lizhi.hou@amd.com>
Overall Series Review
Subject: accel/amdxdna: Add expandable device heap support
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 2
Reviewed: 2026-05-16T08:50:25.638886
---
This single patch converts the amdxdna driver from a single, fixed-size device heap per client to an expandable heap backed by an xarray of heap chunks. The design is reasonable: start with a small heap, grow on demand via userspace IOCTL, and register new chunks with firmware via `MSG_OP_ADD_HOST_BUFFER`. However, there are several locking concerns, a potential off-by-one in the xarray iteration range, missing pin/unpin symmetry for the sync BO path, and some questionable error handling changes that deserve attention.
The patch is a V2 fixing a memory leak and flush-BO scoping, but introduces new issues in those fixes and in the core heap expansion logic. It needs another revision.
---
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-15 22:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 16:19 [PATCH V2] accel/amdxdna: Add expandable device heap support Lizhi Hou
2026-05-15 21:01 ` Mario Limonciello
2026-05-15 22:50 ` Claude review: " Claude Code Review Bot
2026-05-15 22:50 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260515161922.744647-1-lizhi.hou@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox