From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/adreno: Support for CLX feature on A8xx Date: Sat, 16 May 2026 08:47:13 +1000 Message-ID: In-Reply-To: <20260516-a8xx-clx-support-v1-0-62508bf651ac@oss.qualcomm.com> References: <20260516-a8xx-clx-support-v1-0-62508bf651ac@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm/adreno: Support for CLX feature on A8xx Author: Akhil P Oommen Patches: 4 Reviewed: 2026-05-16T08:47:13.384907 --- This is a clean, well-structured 3-patch series adding Current Limit Extension (CLX) support for A8xx GPUs. The design follows established patterns in the driver: patch 1 adds the HFI plumbing (feature control + table messaging), patches 2 and 3 add per-GPU catalog data for A840 and X2-85 respectively. The code is straightforward, the size computation for the variable-length HFI table message is correct, and the series slots CLX into the right place in the `a6xx_hfi_start()` sequence (after ACD, before IFPC). There are two concrete issues worth addressing, both minor. Overall the series looks good. --- --- Generated by Claude Code Patch Reviewer