From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/snapshot: fix dumping of the unaligned regions Date: Sat, 16 May 2026 08:44:40 +1000 Message-ID: In-Reply-To: <20260516-msm-fix-dsi-dump-2-v1-1-43928094d25b@oss.qualcomm.com> References: <20260516-msm-fix-dsi-dump-2-v1-1-43928094d25b@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/msm/snapshot: fix dumping of the unaligned regions Author: Dmitry Baryshkov Patches: 1 Reviewed: 2026-05-16T08:44:40.796210 --- This is a single patch fixing the MSM display snapshot code for unaligned r= egister regions (specifically DSI, which has a 4-byte offset). The core fix= is correct and well-reasoned: it removes premature alignment in the caller= , fixes a 16x memory overallocation bug (`aligned_len * REG_DUMP_ALIGN` whe= re multiplication was used instead of rounding), and adds proper handling f= or partial trailing rows during both register dumping and printing. **However, there is a critical debug filter accidentally left in the patch*= * that makes it unsuitable for merging as-is. The `strcmp(fmt, "dsi%d_ctrl"= )` check at line 187 will silently skip ALL non-DSI snapshot blocks (DPU, D= P, etc.), completely breaking devcoredump for anything other than DSI contr= ollers. **Verdict: Needs revision** =E2=80=94 the debug filter must be removed befo= re merging. The rest of the logic is correct. --- --- Generated by Claude Code Patch Reviewer