From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm/snapshot: fix dumping of the unaligned regions Date: Mon, 18 May 2026 16:49:03 +1000 Message-ID: In-Reply-To: <20260516-msm-fix-dsi-dump-2-v2-1-9e49fb2d240e@oss.qualcomm.com> References: <20260516-msm-fix-dsi-dump-2-v2-1-9e49fb2d240e@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/msm/snapshot: fix dumping of the unaligned regions Author: Dmitry Baryshkov Patches: 1 Reviewed: 2026-05-18T16:49:03.943027 --- This is a single-patch fix for the MSM display snapshot code that handles dumping hardware registers for devcoredump. The patch addresses two related bugs: 1. **Memory overallocation**: The old code treated the `aligned_len` parameter as if it were already in units of `REG_DUMP_ALIGN` (16 bytes), then multiplied it again (`aligned_len * REG_DUMP_ALIGN`), causing 16x overallocation. 2. **Unaligned region truncation**: Regions not aligned to 16 bytes (like DSI ctrl regions, whose size comes from the DT resource size) had their trailing registers silently dropped during printing. The fix is correct, well-scoped, and the commit message clearly explains the problem. The Fixes tag is appropriate. **Verdict: Looks good to merge.** --- Generated by Claude Code Patch Reviewer