From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: mfd: lm3533: convert to OF bindings, improve support Date: Mon, 18 May 2026 16:19:45 +1000 Message-ID: In-Reply-To: <20260517074306.30937-1-clamor95@gmail.com> References: <20260517074306.30937-1-clamor95@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: mfd: lm3533: convert to OF bindings, improve support Author: Svyatoslav Ryhel Patches: 18 Reviewed: 2026-05-18T16:19:45.952487 --- This series converts the LM3533 MFD driver from platform data to Device Tre= e bindings, adds VIN regulator support, a DMA mask workaround, mapping mode= DT support, and LED source muxing from DT. The intent is good =E2=80=94 re= moving dead platform data code and enabling DT-based configuration. However, **the series has several critical bugs that will prevent it from w= orking**, most notably an MFD cell ID mismatch that causes all LED probes t= o fail with `-EINVAL`, a copy-paste register address bug in the LED output = config, and off-by-one errors in the `led-sources` reading logic. The outpu= t config register manipulation approach is also fundamentally flawed =E2=80= =94 it uses wide masks that clobber other banks' configurations. The series= needs a v2 with these issues addressed. --- --- Generated by Claude Code Patch Reviewer