Claude review: drm/amdgpu: fix lock leak on ENOMEM in AMDGPU_GEM_OP_GET_MAPPING_INFO

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/amdgpu: fix lock leak on ENOMEM in AMDGPU_GEM_OP_GET_MAPPING_INFO
Author: Michael Bommarito <michael.bommarito@gmail.com>
Patches: 1
Reviewed: 2026-05-18T16:08:13.978576

---

This is a single-patch series fixing a genuine resource leak bug in `amdgpu_gem_op_ioctl()`. The analysis is correct: when `kvcalloc()` fails at line 1093, the original code returned `-ENOMEM` directly, bypassing the `out_exec` cleanup label. This leaked the `drm_exec` lock context (which holds the GEM object's `dma_resv` and the VM root PD's `dma_resv`) and the `drm_gem_object` reference.

The fix is mechanical and obviously correct — it sets `r = -ENOMEM` and jumps to `out_exec`, which calls `drm_exec_fini(&exec)` and `drm_gem_object_put(gobj)`, matching the cleanup pattern used by every other error path in this function.

The commit message is thorough and well-written. It identifies the specific resources leaked, explains the user-visible impact (unprivileged local DoS via stuck D-state task), references the related work by Ziyi Guo on `num_entries` validation, and correctly notes the fix was not runtime-tested on patched kernel. The `Fixes:` and `Cc: stable` tags are appropriate.

**Verdict: This patch looks correct and ready to apply.**

---

---
Generated by Claude Code Patch Reviewer