From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/bridge: dw-hdmi-qp: Return -EOPNOTSUPP in HDMI audio functions Date: Mon, 25 May 2026 22:33:16 +1000 Message-ID: In-Reply-To: <20260519-fix-hdmi-audio-warnings-v1-1-9608966c993f@collabora.com> References: <20260519-fix-hdmi-audio-warnings-v1-1-9608966c993f@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/bridge: dw-hdmi-qp: Return -EOPNOTSUPP in HDMI audio functions Author: Detlev Casanova Patches: 1 Reviewed: 2026-05-25T22:33:16.962963 --- This is a single-patch series that changes the error code returned by the `= dw_hdmi_qp_audio_enable` and `dw_hdmi_qp_audio_prepare` callbacks from `-EN= ODEV` (and implicit success-when-not-ready) to `-EOPNOTSUPP` when `tmds_cha= r_rate =3D=3D 0` (i.e., HDMI is not connected). The change is well-motivated and correct. The ASoC framework's `snd_soc_ret= ()` function (`sound/soc/soc-utils.c:18-42`) explicitly suppresses logging = for `-EOPNOTSUPP` and `-ENOTSUPP`, while all other negative error codes (in= cluding the previous `-ENODEV`) produce `dev_err` messages. This means the = old code was generating spurious error logs whenever audio operations were = attempted while HDMI was disconnected =E2=80=94 a normal and frequent runti= me condition. The semantic choice is also correct: `-EOPNOTSUPP` ("operation not supporte= d") accurately describes a transient state where the hardware exists but cl= ocks aren't enabled yet, whereas `-ENODEV` ("no such device") incorrectly s= uggests the hardware is absent. **Verdict: Looks good. Suitable for merging.** --- Generated by Claude Code Patch Reviewer