From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/display: hdmi: Add common TMDS character rate constants Date: Mon, 25 May 2026 22:44:49 +1000 Message-ID: In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/display: hdmi: Add common TMDS character rate constants Author: Javier Martinez Canillas Patches: 24 Reviewed: 2026-05-25T22:44:49.028545 --- This is a clean, well-structured cleanup series that introduces four common= TMDS character rate constants (`DRM_HDMI_TMDS_CHAR_RATE_MIN`, `_MAX_1_0`, = `_MAX_1_3`, `_MAX_2_0`) into `` and replaces= per-driver duplicates and magic numbers across 7 driver files. The series = is straightforward and low-risk. The constants are correctly valued per the= HDMI specifications. The series also opportunistically fixes two documenta= tion errors (HDMI 1.4 =E2=86=92 1.3, HDMI =E2=89=A4 1.2 =E2=86=92 HDMI 1.0)= . The one-patch-per-driver split is appropriate for independent merging. No functional changes are introduced =E2=80=94 all replacements are exact v= alue matches against the existing defines or magic numbers. No issues found. **Verdict: Looks good. Ready to merge.** --- --- Generated by Claude Code Patch Reviewer