From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/accel/amdxdna: add debugfs support Date: Mon, 25 May 2026 22:09:05 +1000 Message-ID: In-Reply-To: <20260519203236.252068-1-shofiqtest@gmail.com> References: <20260519203236.252068-1-shofiqtest@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/accel/amdxdna: add debugfs support Author: Md Shofiqul Islam Patches: 2 Reviewed: 2026-05-25T22:09:05.249602 --- **NAK.** This patch is based on a significantly older version of the amdxdna driver and is superseded by work already merged. The current drm-next tree already contains: 1. A fully functional `amdxdna_debugfs.c` (with a carveout debugfs entry) 2. `amdxdna_debugfs.h` with proper `CONFIG_DEBUG_FS` guards 3. The `amdxdna_debugfs_init()` call in `amdxdna_probe()` 4. Conditional Makefile inclusion via `amdxdna-$(CONFIG_DEBUG_FS)` Beyond the conflict with existing code, the patch contains a compilation error and a Makefile correctness issue. The TODO item referenced in the commit message has effectively already been addressed. --- --- Generated by Claude Code Patch Reviewer