From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/atomic: track individual colorop updates Date: Mon, 25 May 2026 22:24:19 +1000 Message-ID: In-Reply-To: <20260519211111.228303-1-mwen@igalia.com> References: <20260519211111.228303-1-mwen@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/atomic: track individual colorop updates Author: Melissa Wen Patches: 12 Reviewed: 2026-05-25T22:24:19.776114 --- This is a well-structured v6 series from Melissa Wen (Igalia) that improves= DRM color pipeline tracking by: (1) scoping colorop state to only active p= ipelines, (2) rejecting updates to inactive colorops, (3) making LUT interp= olation mutable, and (4) propagating colorop changes via `plane_state->colo= r_mgmt_changed` so drivers (AMDGPU demonstrated) can react. The design is sound and the series has good review coverage (Reviewed-by fr= om Harry Wentland and Chaitanya Kumar Borah on several patches). However, *= *Patch 4 has critical compilation errors** that break bisectability =E2=80= =94 two syntax bugs in `__drm_colorop_state_reset` that Patch 5 quietly fix= es. These must be squashed into Patch 4 or the fix moved there. Otherwise the logic across the series is correct and the API changes are cl= ean. --- --- Generated by Claude Code Patch Reviewer