From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add HDMI 2.0 support to DW HDMI QP TX Date: Mon, 25 May 2026 21:15:02 +1000 Message-ID: In-Reply-To: <20260520-dw-hdmi-qp-scramb-v6-0-24b74603b782@collabora.com> References: <20260520-dw-hdmi-qp-scramb-v6-0-24b74603b782@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add HDMI 2.0 support to DW HDMI QP TX Author: Cristian Ciocaltea Patches: 27 Reviewed: 2026-05-25T21:15:02.230257 --- This is a well-structured 22-patch series adding HDMI 2.0 scrambling suppor= t (enabling 4K@60Hz) to the Synopsys DW HDMI QP TX controller, primarily fo= r Rockchip RK3576/RK3588 SoCs. The series is at v6, has collected several R= eviewed-by/Tested-by/Acked-by tags, and shows substantial refinement over p= revious iterations. **Architecture:** The approach is sound =E2=80=94 it builds layered infrast= ructure (SCDC helpers -> connector callbacks -> bridge ops -> bridge_connec= tor wiring -> driver implementation) in a logical progression. The split fr= om 10 to 22 patches is a good decomposition. The SCDC status monitoring via= delayed work, and the CRTC-reset-on-reconnect pattern for restoring SCDC s= tate after hotplug, are well-established patterns in the DRM subsystem (cf.= vc4_hdmi). **Concerns:** I have a few observations ranging from minor to moderate, det= ailed below. --- --- Generated by Claude Code Patch Reviewer