From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: cgroup/dmem: implement dmem.high soft limit and throttling
Date: Mon, 25 May 2026 22:14:45 +1000 [thread overview]
Message-ID: <review-overall-20260520-feature-dmem-high-v1-1-97ca0cb7f95a@gmail.com> (raw)
In-Reply-To: <20260520-feature-dmem-high-v1-1-97ca0cb7f95a@gmail.com>
Overall Series Review
Subject: cgroup/dmem: implement dmem.high soft limit and throttling
Author: Qiliang Yuan <realwujing@gmail.com>
Patches: 7
Reviewed: 2026-05-25T22:14:45.117248
---
This single patch adds a `dmem.high` soft limit to the dmem cgroup controller, modeled after the memory cgroup's `memory.high`. The idea is sound — throttling via return-to-userspace sleep instead of outright allocation failure provides better backpressure for GPU memory. However, the implementation has a **critical sleeping-inside-RCU bug** that will crash the kernel, a **wrong default for the high limit getter**, and several design-level gaps compared to the memcg model it claims to follow (no fast-path guard, no hierarchy walk for high checking). As written, this patch cannot be applied.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-05-25 12:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 6:07 [PATCH] cgroup/dmem: implement dmem.high soft limit and throttling Qiliang Yuan
2026-05-20 9:52 ` Tejun Heo
2026-05-21 11:28 ` Qiliang Yuan
2026-05-21 9:45 ` Maarten Lankhorst
2026-05-21 11:28 ` Qiliang Yuan
2026-05-21 10:52 ` Natalie Vock
2026-05-21 11:28 ` Qiliang Yuan
2026-05-25 12:14 ` Claude review: " Claude Code Review Bot
2026-05-25 12:14 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260520-feature-dmem-high-v1-1-97ca0cb7f95a@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox