From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Let userspace know about swapped out panthor GEM objects Date: Mon, 25 May 2026 21:52:45 +1000 Message-ID: In-Reply-To: <20260520-panthor-bo-reclaim-observability-v4-0-a47ab61cb80d@collabora.com> References: <20260520-panthor-bo-reclaim-observability-v4-0-a47ab61cb80d@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Let userspace know about swapped out panthor GEM objects Author: Nicolas Frattaroli Patches: 8 Reviewed: 2026-05-25T21:52:45.981861 --- This is a clean, well-structured 3-patch series that adds eviction observab= ility to the DRM fdinfo framework and implements it in the panthor driver. = The motivation is sound =E2=80=94 distinguishing evicted-to-swap objects fr= om newly-allocated-but-not-yet-backed objects is genuinely useful for memor= y debugging. The series is at v4 and already carries Reviewed-by from Steve= n Price. The patches are logically ordered: framework first (patch 1), driver implem= entation (patch 2), cosmetic cleanup (patch 3). The code is straightforward= and well-documented. One design concern exists in the framework code (patch 1) regarding how `ad= d_size` is computed for evicted objects =E2=80=94 it's correct for panthor = but could be incorrect for future drivers that implement `rss()`. This is a= minor concern since panthor is the only user today. **Verdict:** Series looks good. One minor design concern worth discussing w= ith maintainers, but not a blocker for merging. --- --- Generated by Claude Code Patch Reviewer