From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add SCDC information to connector debugfs Date: Mon, 25 May 2026 21:49:32 +1000 Message-ID: In-Reply-To: <20260520-scdc-link-health-v2-0-511af18cd64b@collabora.com> References: <20260520-scdc-link-health-v2-0-511af18cd64b@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Add SCDC information to connector debugfs Author: Nicolas Frattaroli Patches: 5 Reviewed: 2026-05-25T21:49:32.850673 --- This is a well-structured 3-patch series that exposes SCDC (Status and Control Data Channel) link health information via connector debugfs, useful for diagnosing HDMI cable/link problems. The overall design is clean: patch 1 adds the core HDMI 2.0 infrastructure, patch 2 wires it into bridge connectors, and patch 3 extends for HDMI 2.1 FRL fields. However, there are several issues ranging from a real bug in the error counter handling for lane 3, to a portability concern with bitfield unions, to an inappropriate comment. The series should be revised before merging. --- --- Generated by Claude Code Patch Reviewer