Claude review: drm/loongson: fix pci_dev refcount leak in lsdc_get_dedicated_vram()

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/loongson: fix pci_dev refcount leak in lsdc_get_dedicated_vram()
Author: yaolu@kylinos.cn
Patches: 5
Reviewed: 2026-05-25T21:54:00.145158

---

This mbox contains two versions of the same patch (v2 and v3) addressing a `pci_dev` refcount leak in the loongson display driver. The v3 patch is the latest and supersedes v2.

**v2** added a `pci_dev_put()` call but kept storing the reference in `ldev->gpu` — which would create a use-after-free risk (putting the reference while still holding a dangling pointer).

**v3** is the correct approach: it removes the unused `ldev->gpu` member entirely and drops the reference immediately after extracting the BAR resource information. This is clean and correct.

The fix is straightforward and addresses a real refcount leak. The `pci_get_domain_bus_and_slot()` function increments the refcount on the returned `pci_dev`, and without a corresponding `pci_dev_put()`, the device reference is leaked. Since the only information needed from `pdev_gpu` is the BAR base/size (extracted via `pci_resource_start`/`pci_resource_len`), there is no need to hold the reference long-term.

**Verdict:** v3 looks good to merge.

---
Generated by Claude Code Patch Reviewer