From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/loongson: mode_config.cursor_width should use hw_cursor_w Date: Mon, 25 May 2026 22:20:19 +1000 Message-ID: In-Reply-To: <20260520015309.35088-1-yaolu@kylinos.cn> References: <20260520015309.35088-1-yaolu@kylinos.cn> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/loongson: mode_config.cursor_width should use hw_cursor_w Author: yaolu@kylinos.cn Patches: 1 Reviewed: 2026-05-25T22:20:19.689476 --- This is a single-patch trivial bugfix for an obvious copy-paste error in the Loongson display controller driver. The `cursor_width` field was being initialized from `hw_cursor_h` (height) instead of `hw_cursor_w` (width). The fix is correct and straightforward. In practice, the current hardware descriptions define `hw_cursor_w == hw_cursor_h` (32x32 for ls7a1000 and 64x64 for ls7a2000/ls2k2000), so this bug had no visible effect. Still, it's clearly wrong and worth fixing. The Fixes tag correctly references the original commit that introduced the Loongson KMS driver. The patch is well-formed. **Verdict: Looks good. No issues found.** --- Generated by Claude Code Patch Reviewer