Claude review: drm: detect panel type from DisplayID 2.x

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm: detect panel type from DisplayID 2.x
Author: Chenyu Chen <chen-yu.chen@amd.com>
Patches: 6
Reviewed: 2026-05-25T22:19:21.187117

---

This 3-patch series adds panel type detection from the DisplayID v2.x Display Parameters Data Block (tag 0x21), resolving a longstanding TODO in amdgpu_dm. The approach is clean: extract a helper, parse a new block type, wire it into the driver. The code is well-structured and correctly handles the detection priority chain (VSDB > DPCD > DisplayID > Samsung heuristic).

However, there is one significant UAPI concern: **`DRM_MODE_PANEL_TYPE_LCD` is added to the UAPI header (`drm_mode.h`) but `drm_panel_type_enum_list` in `drm_connector.c` is not updated**, so the panel type property can never report "LCD" to userspace. Additionally, at the end of `dm_set_panel_type()`, the existing code only exposes `DRM_MODE_PANEL_TYPE_OLED` via the property — anything else becomes `DRM_MODE_PANEL_TYPE_UNKNOWN`. So even after this series, an LCD panel detected via DisplayID will show as "unknown" to userspace. This needs to be either fixed (update the enum list and the property-setting logic) or acknowledged as intentional for internal-only use — in which case `DRM_MODE_PANEL_TYPE_LCD` should not be in a UAPI header.

There are also minor style issues in Patch 1.

---

---
Generated by Claude Code Patch Reviewer