From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/sched: Add test suite for concurrent job submissions Date: Mon, 25 May 2026 22:03:53 +1000 Message-ID: In-Reply-To: <20260520093350.1036001-1-marco.pagani@linux.dev> References: <20260520093350.1036001-1-marco.pagani@linux.dev> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/sched: Add test suite for concurrent job submissions Author: Marco Pagani Patches: 1 Reviewed: 2026-05-25T22:03:53.463315 --- This is a single well-structured patch (v4) adding a KUnit test suite for concurrent job submissions to the DRM GPU scheduler. It covers two complementary scenarios: parallel bulk submission and interleaved submission-with-completion using a sliding window. The concurrency infrastructure (unbounded workqueue, start-gun completion, per-worker entities) is sound, and the v4 teardown ordering fix correctly addresses the use-after-free reported in v3. The code is clean, follows existing test patterns in the file, and the cleanup logic handles early assertion failures safely. I have a few minor observations but no blocking issues. **Verdict: Looks good overall. Minor comments below.** --- Generated by Claude Code Patch Reviewer