From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: dma-buf: set SB_I_NOEXEC on the pseudo filesystem Date: Mon, 25 May 2026 21:11:46 +1000 Message-ID: In-Reply-To: <20260520214350.168689-1-jhubbard@nvidia.com> References: <20260520214350.168689-1-jhubbard@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: dma-buf: set SB_I_NOEXEC on the pseudo filesystem Author: John Hubbard Patches: 3 Reviewed: 2026-05-25T21:11:46.873174 --- This is a single-patch fix, not a series. The patch is **correct, well-moti= vated, and straightforward**. It fixes a real regression introduced by comm= it `1e7ab6f67824` ("anon_inode: rework assertions") in 6.17, where `path_no= exec()` now warns (via `VFS_WARN_ON_ONCE`) when an `S_ANON_INODE` inode is = encountered on a superblock that lacks `SB_I_NOEXEC`. The dma-buf pseudo fi= lesystem uses `alloc_anon_inode()` (via `init_pseudo`) but never set `SB_I_= NOEXEC`, triggering the warning on any dma-buf mmap. The fix follows the established pattern used by every other pseudo filesyst= em in the kernel that issues anonymous inodes (`anon_inodes.c`, `aio.c`, `s= ecretmem.c`, `guest_memfd.c`, `pidfs.c`, `nsfs.c`, etc.) =E2=80=94 all set = `fc->s_iflags |=3D SB_I_NOEXEC` in their `init_fs_context` callback. The `Fixes:` tag and `Cc: stable` are appropriate since this is a regressio= n fix for a new assertion. No concerns with this patch. --- Generated by Claude Code Patch Reviewer