From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/amdgpu: Unify vm_fault_interrupt_state logic for gmc v10 and v12_0 Date: Mon, 25 May 2026 20:48:58 +1000 Message-ID: In-Reply-To: <20260520224217.17615-1-ryan.oliveiraf@usp.br> References: <20260520224217.17615-1-ryan.oliveiraf@usp.br> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: drm/amdgpu: Unify vm_fault_interrupt_state logic for gmc v10 and v= 12_0 Author: Ryan Oliveira Patches: 1 Reviewed: 2026-05-25T20:48:58.745626 --- This is a single-patch series that consolidates the identical `vm_fault_int= errupt_state` function from `gmc_v10_0.c` and `gmc_v12_0.c` into a shared h= elper in `amdgpu_gmc.c`. The refactoring is straightforward and correct =E2= =80=94 the two removed implementations are byte-for-byte identical, so the = consolidation is safe. The patch is simple, low-risk, and does what it says. However, there are a = couple of issues worth addressing. **Verdict:** Needs minor fixes before merging. --- --- Generated by Claude Code Patch Reviewer