From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add support to 2 panels in bonded-DSI mode Date: Mon, 25 May 2026 20:00:01 +1000 Message-ID: In-Reply-To: <20260521-sm8650-7-1-bonded-dsi-v4-0-a4dd5e0850f1@linaro.org> References: <20260521-sm8650-7-1-bonded-dsi-v4-0-a4dd5e0850f1@linaro.org> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add support to 2 panels in bonded-DSI mode Author: Jun Nie Patches: 10 Reviewed: 2026-05-25T20:00:01.551184 --- This v4 series adds support for driving two independent physical DSI panels= in bonded-DSI mode from a single CRTC, targeting VR headset use cases (lef= t/right eye panels). It touches the MSM DSI host driver to support `slice_p= er_pkt > 1` for DSC and dual-panel frame width halving, adds a `dual_panel`= flag to the core MIPI DSI struct, introduces a new DT binding, and adds a = panel driver for the Synaptics R63455.=20 The overall architecture =E2=80=94 having the panel driver register the sec= ond DSI device and set `dual_panel` so the host halves the frame =E2=80=94 = is reasonable, though several issues need attention before this can be merg= ed: 1. **Build breakage**: The panel driver uses `backlight_properties.pulse_of= fset_rows`, which does not exist in the kernel backlight struct. This will = fail to compile. 2. **`dsc_slice_per_pkt` placement**: Adding a non-standard field to `struc= t drm_dsc_config` (a struct that maps to the DSC standard parameter set) is= debatable and needs DRM maintainer buy-in. 3. **Missing division-by-zero guard**: `dsc_slice_per_pkt` is used as a div= isor without validation. 4. **DT binding issues**: YAML schema errors and questionable use of vendor= -prefixed supply names instead of generic ones. 5. **Panel driver quality**: Uses deprecated API (`of_device_get_match_data= `), includes an unused header, and has error-handling gaps. --- Generated by Claude Code Patch Reviewer