From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Support sparse mappings in Panthor Date: Mon, 25 May 2026 21:08:32 +1000 Message-ID: In-Reply-To: <20260521014359.2011484-1-adrian.larumbe@collabora.com> References: <20260521014359.2011484-1-adrian.larumbe@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Support sparse mappings in Panthor Author: =3D?UTF-8?q?Adri=3DC3=3DA1n=3D20Larumbe?=3D Patches: 8 Reviewed: 2026-05-25T21:08:32.491296 --- This is v12 of a 6-patch series adding sparse mapping support to the Pantho= r (Mali CSF) GPU driver. The approach uses a per-file-context 2MiB dummy BO= that is cyclically mapped over sparse VA ranges, working around the hardwa= re's lack of native sparse page table entries. The series is well-structure= d: preparatory cleanups (patches 1-4), the main feature (patch 5), and a ve= rsion bump (patch 6). Patches 1-4 all carry Reviewed-by tags from both Stev= en Price and Boris Brezillon. The core design is sound =E2=80=94 using a real Panthor BO for the dummy bu= ffer reuses the existing shrinker infrastructure, and per-file-context isol= ation prevents information leaks. However, patch 5 has a few issues worth e= xamining, primarily around type truncation in the sparse mapping loop, the = offset semantics during remap operations, and the `size > 0` guard that app= eared without explanation. Overall this is a mature series (v12) and the architectural decisions are w= ell-justified. The issues below range from potential bugs to style/clarity = nits. --- Generated by Claude Code Patch Reviewer