From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: perf: complete perf_allow_* trio and use in drm/xe Date: Mon, 25 May 2026 21:03:40 +1000 Message-ID: In-Reply-To: <20260521024904.331912-1-jhubbard@nvidia.com> References: <20260521024904.331912-1-jhubbard@nvidia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: perf: complete perf_allow_* trio and use in drm/xe Author: John Hubbard Patches: 3 Reviewed: 2026-05-25T21:03:40.409223 --- This is a clean, well-motivated 2-patch series from John Hubbard. Patch 1 promotes `perf_allow_cpu()` and `perf_allow_tracepoint()` from static inlines in `` to out-of-line `EXPORT_SYMBOL_GPL` functions in `kernel/events/core.c`, following the existing pattern of `perf_allow_kernel()`. Patch 2 uses the newly-exported `perf_allow_cpu()` in drm/xe to replace open-coded permission checks, aligning xe observation with the system-wide perf security policy. The series is logically structured, the commit messages are excellent, and the code transformations are straightforward. The behavioral change in patch 2 is intentional and clearly documented: xe observation now respects `kernel.perf_event_paranoid` and the LSM `security_perf_event_open()` hook, rather than doing a simple `perfmon_capable()` check. There is one potential build issue worth flagging and one minor semantic concern. Overall this looks good to merge. --- Generated by Claude Code Patch Reviewer