From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: misc: fastrpc: Add polling mode support Date: Mon, 25 May 2026 20:54:20 +1000 Message-ID: In-Reply-To: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> References: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: misc: fastrpc: Add polling mode support Author: Ekansh Gupta Patches: 5 Reviewed: 2026-05-25T20:54:20.772819 --- This is a 4-patch series (v12) adding polling mode support to the Qualcomm = FastRPC driver. The series is structured well: patches 1-3 are preparatory = refactors (moving `fdlist` to context, switching to `GENMASK`/`FIELD_GET`, = and expanding the context ID mask), and patch 4 adds the actual polling mod= e feature. The overall approach is sound =E2=80=94 polling on shared memory to avoid C= PU wakeup latency is a well-understood optimization for latency-sensitive R= PC paths, with a fallback to interrupt-based completion on timeout. The preparatory patches (1-3) are clean, well-reviewed (R-b from Dmitry Bar= yshkov and Konrad Dybcio), and look correct. Patch 4 has a few issues worth= discussing, ranging from a potential data race to UAPI design consideratio= ns. --- Generated by Claude Code Patch Reviewer