From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Add eDP support for RK3576 Date: Mon, 25 May 2026 20:40:11 +1000 Message-ID: In-Reply-To: <20260521080835.1362416-1-damon.ding@rock-chips.com> References: <20260521080835.1362416-1-damon.ding@rock-chips.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Add eDP support for RK3576 Author: Damon Ding Patches: 15 Reviewed: 2026-05-25T20:40:11.834988 --- This is a well-structured v6 series adding eDP support for the RK3576 SoC. = The series is cleanly decomposed into three logical groups: (1) fixing the = RK3588 hclk clock dependency (patches 1-5), (2) adding RK3576 DT bindings a= nd nodes (patches 6-7), and (3) adding driver support for RK3576 (patches 8= -10). The code reuses the existing RK3588 infrastructure appropriately, and= the series has already accumulated several Reviewed-by/Acked-by tags from = prior iterations. The series is in good shape overall. The main technical concern is the miss= ing `edp_mode` GRF field in the RK3576 chip data (patch 10) =E2=80=94 while= the code is *safe* due to the `valid` flag check in `rockchip_grf_field_wr= ite()`, the commit message claims RK3576 "fully matches the proven RK3588 d= esign" yet omits this field that RK3588 uses. This deserves clarification. = There are also a few minor tag ordering and commit message nits. No blocking issues found. --- Generated by Claude Code Patch Reviewer